Open
Conversation
nuclearsandwich
left a comment
There was a problem hiding this comment.
I could see some utility in --mixin verbose to manage the console_direct event handler but I don't think there's any advantage to creating a mixin for the merge-install flag.
| { | ||
| "build": { | ||
| "merge-install": { | ||
| "merge-install": "True" |
There was a problem hiding this comment.
Can you explain how you use this?
Without the mixin, an invocation would use
colcon build --merge-instal ...
But with the mixin it would be
colcon build --mixin merge-install
to do the exact same thing so I don't think this mixin makes sense.
Author
There was a problem hiding this comment.
When you put it this way, it does seem odd. My use case includes other things, like many cmake arguments and so on. I've struggled to add this as an additional option, so I wanted to leave it here as an example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I struggle to get these configs working for me, so I think it might be helpful to add such examples.