Skip to content

Default to 'off' when invoked on an obviously SSH shell#76

Merged
cottsay merged 1 commit intomasterfrom
cottsay/disable-over-ssh
Nov 17, 2025
Merged

Default to 'off' when invoked on an obviously SSH shell#76
cottsay merged 1 commit intomasterfrom
cottsay/disable-over-ssh

Conversation

@cottsay
Copy link
Copy Markdown
Member

@cottsay cottsay commented Oct 11, 2025

While this doesn't determine if invoked over an SSH shell with 100% certainty (like if sudo is involved), it's a trivial hint that the user probably doesn't want desktop notifications enabled.

Note that the behavior can still be specified either way, we're just changing the default behavior here.

Inspired by: #31 (comment)

While this doesn't determine if invoked over an SSH shell with 100%
certainty (like if sudo is involved), it's a trivial hint that the user
probably doesn't want desktop notifications enabled.

Note that the behavior can still be specified either way, we're just
changing the default behavior here.
@cottsay cottsay self-assigned this Oct 11, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 11, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 19.21%. Comparing base (e535828) to head (b80367b).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...ion/event_handler/desktop_notification/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   19.25%   19.21%   -0.05%     
==========================================
  Files           9        9              
  Lines         431      432       +1     
  Branches       65       66       +1     
==========================================
  Hits           83       83              
- Misses        335      336       +1     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@Crola1702 Crola1702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cottsay cottsay merged commit b43e29d into master Nov 17, 2025
22 checks passed
@cottsay cottsay deleted the cottsay/disable-over-ssh branch November 17, 2025 21:28
@cottsay cottsay added this to the 0.3.0 milestone Mar 27, 2026
@cottsay cottsay added the enhancement New feature or request label Mar 27, 2026
@cottsay cottsay modified the milestones: 0.3.0, 0.3.1 Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

3 participants