Introduced a Loading Screen #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a loading screen to be displayed while the user is waiting for the MindsDB server to launch.
This implementation solves another existing issue; the current execution of the extension redirects the user directly to http://localhost:47334, which is where the MindsDB server runs. However, if the server has not yet started by the time the user clicks on the extension tab, until the user clicks out of it and clicks on it again (which is when the extension specific code, i.e. index.html runs), the server will not be launched in Docker Desktop.
The above issue is resolved by periodically checking (in 2 second intervals) if the server is running on http://localhost:47334 and redirecting the user only when it is up. The loading screen is displayed during the meantime.