fix Twirl example to correctly render in a browser#189
Merged
lihaoyi merged 1 commit intocom-lihaoyi:masterfrom Jan 1, 2026
Merged
fix Twirl example to correctly render in a browser#189lihaoyi merged 1 commit intocom-lihaoyi:masterfrom
lihaoyi merged 1 commit intocom-lihaoyi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When I tried the Twirl example in my browser, I noticed the HTML wasn't rendering. This is due to the
Content-Typeheader coming back astext/plaininstead oftext/htmlChange
I build a full cask.Response object so I can set the content-type header. Ideally there is a better way to set this up. As I'm only just poking at the framework I'm not sure what the best way is, but I'm submitting what worked for me.