Partial string search support #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic auth params added
| @@ -93,4 +93,4 @@ | |||
| "peerDependencies": { | |||
| "axios": "^0.27.2" | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
nit: Can you re-add the newline at the end of this file please?
| import { Mapper } from './mapping/Mapper'; | ||
| import type { SklEngineOptions } from './SklEngineOptions'; | ||
| import type { FindOperator } from './storage/FindOperator'; | ||
| import type { FindAllOptions, FindOneOptions, FindOptionsWhere } from './storage/FindOptionsTypes'; | ||
| import type { |
There was a problem hiding this comment.
Thanks for cleaning up these imports!
| @@ -55,11 +66,13 @@ import { SKL, SHACL, RDFS, SKL_ENGINE, XSD, RDF } from './util/Vocabularies'; | |||
|
|
|||
| export type VerbHandler = <T extends OrArray<NodeObject> = OrArray<NodeObject>>( | |||
| params: JSONObject, | |||
| verbConfig?: VerbConfig, | |||
| verbConfig?: VerbConfig | |||
There was a problem hiding this comment.
nit: We prefer the trailing comma here
| @@ -0,0 +1,21 @@ | |||
| export class Logger { | |||
There was a problem hiding this comment.
Thanks for adding this. We can make it better over time for example by adding winston.
Looks like there are a couple linter items here. You can eslint ignore the one about console.log
|
Please rebase with |
|
There are still tons of auto-formatting changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
containsoperator for partial string match in queries.