Merge pull request #376 from johndkane/remove-duplicate-code

ericnewton76 · web-flow · commit a9243e96820f · 2019-02-01T12:07:37.000-05:00
Remove duplication by delegating calls to CreateDefaultImmutableInsta…
diff --git a/src/CommandLine/Infrastructure/ReflectionHelper.cs b/src/CommandLine/Infrastructure/ReflectionHelper.cs
@@ -79,11 +79,8 @@ public static bool IsFSharpOptionType(Type type)
 
         public static T CreateDefaultImmutableInstance<T>(Type[] constructorTypes)
         {
-            var t = typeof(T);
-            var ctor = t.GetTypeInfo().GetConstructor(constructorTypes);
-            var values = (from prms in ctor.GetParameters()
-                          select prms.ParameterType.CreateDefaultForImmutable()).ToArray();
-            return (T)ctor.Invoke(values);
+            var t = typeof(T);            
+            return (T)CreateDefaultImmutableInstance(t, constructorTypes);
         }
 
         public static object CreateDefaultImmutableInstance(Type type, Type[] constructorTypes)

Original file line number	Diff line number	Diff line change
`@@ -79,11 +79,8 @@ public static bool IsFSharpOptionType(Type type)`
`79`	`79`
`80`	`80`	`public static T CreateDefaultImmutableInstance<T>(Type[] constructorTypes)`
`81`	`81`	`{`
`82`		`- var t = typeof(T);`
`83`		`- var ctor = t.GetTypeInfo().GetConstructor(constructorTypes);`
`84`		`- var values = (from prms in ctor.GetParameters()`
`85`		`- select prms.ParameterType.CreateDefaultForImmutable()).ToArray();`
`86`		`- return (T)ctor.Invoke(values);`
	`82`	`+ var t = typeof(T);`
	`83`	`+ return (T)CreateDefaultImmutableInstance(t, constructorTypes);`
`87`	`84`	`}`
`88`	`85`
`89`	`86`	`public static object CreateDefaultImmutableInstance(Type type, Type[] constructorTypes)`