Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to Display Width Tests #278

Conversation

Oddley
Copy link

@Oddley Oddley commented Apr 23, 2018

Explicitly passing MaximumDisplayWidth = 80 to tests that fail unless your Maximum Display Width is 80

Copy link
Member

@ericnewton76 ericnewton76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I've run into this problem before with the tests and display width being different on my machine, vs appveyor, and another user found out that running inside a default docker container would get different results as well.

@ericnewton76 ericnewton76 added this to the 2.2 patches milestone May 11, 2018
@ericnewton76 ericnewton76 merged commit 8930598 into commandlineparser:develop May 11, 2018
@LeslieMurphy
Copy link

I did some testing - looks like this issue actually got fixed a while back.  It works as of 2.4 and later. 

Fails on 2.3 and earlier with exception System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter 'value')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants