-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default verb support #556
Conversation
Thanks @Artentus for your work.
|
The error with more than one default verb is expected. However I do agree a more descriptive error message could be useful. As for the help text, I'll first have to see how that is actually implemented before I can modify it. Will see what I can do. |
You can concentrate in the error handling and its unit test and push the modification, so I can start review the PR. |
Done, there is now proper error handling and a couple of new unit tests. |
It's nice if you git rebase to origin\develop to sync the last changes in develop branch. |
Co-authored-by: Mohamed Hassan <[email protected]>
Co-Authored-By: Mohamed Hassan <[email protected]>
Co-Authored-By: Mohamed Hassan <[email protected]>
Co-Authored-By: Mohamed Hassan <[email protected]>
Co-Authored-By: Mohamed Hassan <[email protected]>
Sorry it took me so long, have been busy this week, but everything is merged now. I see you don't want to allow default verbs with no name. My reasoning behind this was to just have it behave like no verb at all. Functionally it doesn't change anything tho. |
Thanks @Artentus for Update. |
* Add MyGet package provider to consume the daily builds. (commandlineparser#566) * Options groups take in account default value * Do not allow options groups and exclusive set names to be used together * Multiple group errors are shown together * MissingGroupOptionError compare option names Co-authored-by: Mohamed Hassan <[email protected]>
Merged manually to resolve merge confliction at commit 4bed3432c |
I added basic support for a default verb (a verb that will be assumed if no verb is specified).
Tests all completed on my end but I'm not too knowledgable about this code, if there is any problem let me know.