Skip to content

update JSON schema ID to match merged main branch #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fmigneault
Copy link
Contributor

No description provided.

@fmigneault
Copy link
Contributor Author

@mr-c FYI

Since the 1.2.1_proposed branch was merged, the $id does not resolve to the same URL as:
https://raw.githubusercontent.com/common-workflow-language/cwl-v1.2/v1.2.1/json-schema/cwl.yaml

This PR is targeting https://github.com/common-workflow-language/cwl-v1.2/tree/main, but a corresponding one would be needed for https://github.com/common-workflow-language/cwl-v1.2/tree/v1.2.1

Would that cause an issue in terms of tag override?

@mr-c
Copy link
Member

mr-c commented May 31, 2025

@mr-c FYI

Since the 1.2.1_proposed branch was merged, the $id does not resolve to the same URL as: https://raw.githubusercontent.com/common-workflow-language/cwl-v1.2/v1.2.1/json-schema/cwl.yaml

This PR is targeting https://github.com/common-workflow-language/cwl-v1.2/tree/main, but a corresponding one would be needed for https://github.com/common-workflow-language/cwl-v1.2/tree/v1.2.1

Would that cause an issue in terms of tag override?

I agree that each branch/tag needs a new commit updating the id field. However, since there will be no more changes to the syntax of CWL v1.2, maybe they should have the same value, like `https://w3id.org/cwl/v1.2/cwl-json-schema.yaml'?

@fmigneault
Copy link
Contributor Author

Yes. That would work as well. Even better would be for that URI to also resolves/host the file, so it is somewhat more "official" than the GitHub location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants