Integrate ECS File Transfer #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhavcompanieshouse
force-pushed
the
JU-874/File-Transfer-Changes
branch
from
7c99b92 to
ed2490f
Compare
markpit
approved these changes
Feb 26, 2025
vaibhavcompanieshouse
force-pushed
the
JU-874/File-Transfer-Changes
branch
6 times, most recently
from
9680c3b to
2fd58b8
Compare
dtoulcher-ch
requested changes
Mar 5, 2025
src/main/java/uk/gov/companieshouse/extensions/api/attachments/file/FileTransferApiClient.java
Show resolved
Hide resolved
| LinkedMultiValueMap<String, Object> multipartReqMap = new LinkedMultiValueMap<>(); | ||
| multipartReqMap.add(UPLOAD, fileHttpEntity); | ||
| return multipartReqMap; | ||
| String getFileExtension(String filename) { |
There was a problem hiding this comment.
Couple of comments on the obtaining the extension.
- Should the method be private
- What if the filename starts or ends with a
. - Are we likely to have a filename set to
null
src/main/java/uk/gov/companieshouse/extensions/api/config/ApplicationConfiguration.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I've run mvn dependency:analyze and it suggests
uk.gov.companieshouse:api-sdk-javashould be declareduk.gov.companieshouse:environment-reader-libraryis declared but not used (worth checking incase it's no longer required)
Running mvn versions:display-dependency-updates -DprocessDependencyManagement=false -DprocessPlugins=false -DskipTests has flagged a few dependencies could be updated to newer versions. Spring boot for example has now released 3.4.3
Integrate ECS File Transfer and replace the lambda file transfer with private-api-sdk framework, resolves https://companieshouse.atlassian.net/browse/JU-1277
vaibhavcompanieshouse
force-pushed
the
JU-874/File-Transfer-Changes
branch
from
2fd58b8 to
3e31c86
Compare
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate ECS File Transfer and replace the lambda file transfer with private-api-sdk framework, resolves https://companieshouse.atlassian.net/browse/JU-1277