[Do Not Merge] Bugfix and updates to Embed script parameter handling #1915
+489
−454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ballPointPenguin
force-pushed
the
br/better-embed-param-handling
branch
from
870bd19 to
8e204ba
Compare
tevko
approved these changes
Feb 12, 2025
ballPointPenguin
changed the title
ballPointPenguin
force-pushed
the
br/better-embed-param-handling
branch
from
8e204ba to
8e3172a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Thing
Fixed a bug that caused "footer" to always appear on embedded convos, despite
ucsf=false("user can see footer")The bug was introduced in March 2023 here: 683a75f
Refactoring
Along the way, I couldn't help but to clean up and modernize the
embed.jsandembedPreprod.jsfiles. I relied on new and existing Cypress testing to validate.Extras
browserslistin client-participationmake rebuild-webshortcut in Makefile, for rebuilding/restarting client apps