Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xeus cpp build #409

Merged
merged 3 commits into from
Dec 24, 2024
Merged

Conversation

mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

This changes the ci which builds the emscripten version of xeus-cpp to match the PR in https://github.com/compiler-research/xeus-cpp/pull/199/files

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@anutosh491
Copy link
Collaborator

Thanks for the PR, once done I shall try reviewing it.

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.87%. Comparing base (6cc66be) to head (3e2e020).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #409   +/-   ##
=======================================
  Coverage   70.87%   70.87%           
=======================================
  Files           9        9           
  Lines        3533     3533           
=======================================
  Hits         2504     2504           
  Misses       1029     1029           

@anutosh491
Copy link
Collaborator

Curious about few things
i) Did we rebuild the cache to use llvm 19.1.6
ii) If yes, maybe consider going through this comment of mine (compiler-research/xeus-cpp#199 (comment))

The above would allow simple stuff (like hello world etc) to run absolutely as we expect it to but problems would arise when we are interested in anything to do with files or using Jupyter Lite's file system for accessing anything. For eg

#include <iostream>
#include <fstream>

std::ofstream outfile ("userfile.txt");

outfile << "custom user file!" << std::endl;

outfile.close();

@mcbarton
Copy link
Collaborator Author

@anutosh491 I'm just about the rebuild the cache with this patch https://github.com/emscripten-forge/recipes/blob/main/recipes/recipes_emscripten/llvm/patches/shift_temporary_files_to_tmp_dir.patch

@anutosh491
Copy link
Collaborator

anutosh491 commented Dec 22, 2024

Thank you. Another thing which maybe you could do here, is to just improve the emscripten build instructions accordingly ?

@mcbarton
Copy link
Collaborator Author

mcbarton commented Dec 22, 2024

Thank you. Another thing which maybe you could do here, is to just improve the emscripten build instructions accordingly ?

@anutosh491 I will do this tomorrow morning.

@anutosh491
Copy link
Collaborator

Absolutely fine ;)

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@anutosh491
Copy link
Collaborator

anutosh491 commented Dec 22, 2024

That being said, merging this before the xeus-cpp PR doesn't make sense correct ?
We also want the source code changes that are present on the xeus-cpp PR which would be fetched from HEAD while building xeus-cpp-lite through cppinterop's CI

@anutosh491
Copy link
Collaborator

cc @mcbarton

@vgvassilev vgvassilev merged commit 91c6eda into compiler-research:main Dec 24, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants