-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix xeus cpp build #409
Fix xeus cpp build #409
Conversation
Thanks for the PR, once done I shall try reviewing it. |
Curious about few things The above would allow simple stuff (like hello world etc) to run absolutely as we expect it to but problems would arise when we are interested in anything to do with files or using Jupyter Lite's file system for accessing anything. For eg
|
@anutosh491 I'm just about the rebuild the cache with this patch https://github.com/emscripten-forge/recipes/blob/main/recipes/recipes_emscripten/llvm/patches/shift_temporary_files_to_tmp_dir.patch |
Thank you. Another thing which maybe you could do here, is to just improve the emscripten build instructions accordingly ? |
@anutosh491 I will do this tomorrow morning. |
Absolutely fine ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
That being said, merging this before the xeus-cpp PR doesn't make sense correct ? |
cc @mcbarton |
Description
Please include a summary of changes, motivation and context for this PR.
This changes the ci which builds the emscripten version of xeus-cpp to match the PR in https://github.com/compiler-research/xeus-cpp/pull/199/files
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist