Skip to content

Install libarchive c to remove jupyter lite build warning ci #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

This PR installs libarchive-c to hopefully silence this warnining https://github.com/compiler-research/xeus-cpp/actions/runs/12721180808/job/35463797647#step:7:441 when building a jupyter lite site in the ci.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (ddeb5ca) to head (48b0ad6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   80.72%   80.72%           
=======================================
  Files          19       19           
  Lines         970      970           
  Branches       93       93           
=======================================
  Hits          783      783           
  Misses        187      187           

@mcbarton mcbarton requested a review from anutosh491 January 11, 2025 10:43
@mcbarton
Copy link
Collaborator Author

@anutosh491 can you review this PR?

@anutosh491
Copy link
Collaborator

anutosh491 commented Jan 14, 2025

Could you report this issue upstream https://github.com/jupyterlite/xeus
and figure out if this is the way to go ahead ?

If yes, we should make a note of it upstream !
Converting to draft until then

@anutosh491 anutosh491 marked this pull request as draft January 14, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants