Fix clang-format workflow #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
=======================================
Coverage 80.72% 80.72%
=======================================
Files 19 19
Lines 970 970
Branches 93 93
=======================================
Hits 783 783
Misses 187 187
|
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Looks okay to me but we know the CI would wail for the emscripten build. I'll look into that first and then we can move this in ! |
anutosh491
reviewed
Feb 7, 2025
| @@ -5,7 +5,6 @@ | |||
| * * | |||
| * The full license is in the file LICENSE, distributed with this software. * | |||
| ****************************************************************************/ | |||
|
|
|||
There was a problem hiding this comment.
Not sure why this line was removed.
anutosh491
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
The clang format workflow is broken because it tries to get a git-clang-format by wgetting it. Git-clang-format is not used as far as I can tell from the workflow, so should be safe to just remove the 'Download git-clang-format' section of the workflow.
Fixes # (issue)
Type of change
Please tick all options which are relevant.