Skip to content

Remove lower bound version on cpp-argparse environment-dev.yml #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Mar 6, 2025

Description

Please include a summary of changes, motivation and context for this PR.

Conda will automatically pick the most recent release of cpp-argparse it can. Therefore the lower bound is not necessary in the yml file. We just need to make sure we don't pick a version 4 release when it happens in case we are not compatible with it.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.56%. Comparing base (3b1b82a) to head (0e42de7).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
- Coverage   80.87%   80.56%   -0.32%     
==========================================
  Files          20       20              
  Lines         957      957              
  Branches       88       88              
==========================================
- Hits          774      771       -3     
- Misses        183      186       +3     

see 1 file with indirect coverage changes

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anutosh491
Copy link
Collaborator

Hmm, I guess we don't need anything. We don't have any bound on our feedstock

https://github.com/conda-forge/xeus-cpp-feedstock/blob/main/recipe/meta.yaml#L30

If we think any update would bring any failure (like any deprecation or anything)
in that case we can probably make a release with the last compatible argparse and then shift to the later version.

@anutosh491
Copy link
Collaborator

Let's just remove any bound on argparse from everywhere

https://github.com/search?q=repo%3Acompiler-research%2Fxeus-cpp%20%3E%3D3.0%2C%3C4.0&type=code

@mcbarton mcbarton force-pushed the Remove-lower-bound-on-cppargparse branch 2 times, most recently from 0ee741c to cc64083 Compare March 9, 2025 21:02
@mcbarton
Copy link
Collaborator Author

mcbarton commented Mar 9, 2025

@anutosh491 I've applied your suggestion, and the PR is ready for another review

@anutosh491
Copy link
Collaborator

Perfect, let's move it in !

| `xeus-cpp` | `xeus-zmq` | `CppInterOp` | `pugixml` | `cpp-argparse`| `nlohmann_json` |
|------------|-----------------|--------------|-----------|---------------|-----------------|
| main | >=3.0.0,<4.0.0 | >=1.5.0 | ~1.8.1 | >=3.0,<4.0 | >=3.11.3,<4.0 |
Copy link
Collaborator

@anutosh491 anutosh491 Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait this table isn't just meant to show restrictions correct ? It meant to show whatever dependencies we currently use too ! So creating a new table and removing cpp-argparse from there might not be the way to go (we still depend on it correct) ? We just need to paste whatever latest cpp-argparse is being used (which can be dynamic if there is any update) so I think >=3,<4 does the job isn't it ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anutosh491 I was basing this on the fact we state the direct dependencies just above in the readme (see https://github.com/compiler-research/xeus-cpp?tab=readme-ov-file#dependencies )

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always considered that table as a weird way of expressing a list of dependencies and their constrains. Either we drop the entire table or we keep it and keep arg-parse in there. We are not entirely correct that arg-parse is version agnostic because some time ago in some version they introduced a breaking change...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As one of the suggestions I've removed the table in its entirety. I very much doubt anyone is going to go back and build one of these older releases, and if they are, they could just use the environment file in the repo as a guideline.

@mcbarton mcbarton force-pushed the Remove-lower-bound-on-cppargparse branch from cc64083 to 786affd Compare April 3, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants