Fix typos in repo #285
Open
Fix typos in repo #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
- Coverage 80.87% 80.56% -0.32%
==========================================
Files 20 20
Lines 957 957
Branches 88 88
==========================================
- Hits 774 771 -3
- Misses 183 186 +3 🚀 New features to boost your workflow:
|
vgvassilev
reviewed
Apr 9, 2025
| <name>select_on_container_copy_contruction</name> | ||
| <anchorfile>cpp/memory/polymorphic_allocator/select_on_container_copy_contruction</anchorfile> | ||
| <name>select_on_container_copy_construction</name> | ||
| <anchorfile>cpp/memory/polymorphic_allocator/select_on_container_copy_construction</anchorfile> |
There was a problem hiding this comment.
I believe this file came from the "internet". Maybe we should not touch it.
There was a problem hiding this comment.
I also thought this came from somewhere on the internet, but the document on these lines is wrong . Its supposed to be pointing to https://en.cppreference.com/w/cpp/memory/polymorphic_allocator/select_on_container_copy_construction (with the end of the link being the anchorfile), but as you can the anchorfile is not correct, due to the typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
This PR fixes some typos in the repo.
Fixes # (issue)
Type of change
Please tick all options which are relevant.