-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test cases for xutils #37
Conversation
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. Thanks for the PR.
Maybe update the PR title , "Add test cases" seems vague (be more specific)
Also why did you convert this pr to draft, were we about to add something else too ?
@anutosh491 I thought of adding more test cases for other cpp files, but I will add and create a new pr after understanding more about the repo. |
The coverage not did not detect coverage increase. Is that expected? |
@anutosh491 @vgvassilev Code base has been rebased and pushed. |
clang-tidy review says "All clean, LGTM! 👍" |
Is that PR still related? |
Nop, the same features were added in #36 . |
Can you close it then? |
This pull request adds particular test cases for xeus-cpp.
should_print_version
: Checks when the right or wrong argument is passed for the required syntax.