-
Notifications
You must be signed in to change notification settings - Fork 36
Remove unused xeus-cling and xtensor images #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
=======================================
Coverage 82.05% 82.05%
=======================================
Files 21 21
Lines 858 858
Branches 89 89
=======================================
Hits 704 704
Misses 154 154 🚀 New features to boost your workflow:
|
37c8b49 to
cb45bf3
Compare
cb45bf3 to
da0796e
Compare
|
Yes, but why is this different than other libraries? |
I think that's because xeus-cling which was maintaining the responsible tagfiles for separate libraries as shown here (https://github.com/jupyter-xeus/xeus-cling/tree/main/etc/xeus-cling/tags.d). This is the not best approach right ? we don't want to host tagfiles for each library in our code. Rather how xeus-cpp does it is, if a library author wants to support inline documentation through a notebook, they just need to generate and host tagfiles in their source itself and when we fetch the package the tagfiles land in our prefix from where we can use them. I think Johan and I discussed this long back but yeah this can be improved on I think for sure ? Some kind of mechanism to generate the required files basically ! |
|
Was the conclusion of the review of this PR that the images should be removed or not? I cannot tell from the comments. It seems the xtensor image is in here due to a mechanism for automatically generating the image not existing (and its being treated differently to other libraries), but I don't see the point of the xeus-cling image even if that was the case. |
|
These images were actually directly used in the xeus-cling demo notebook itself. Since they are not used anymore, I think they should be removed. |

As far as I can tell these images are not being used anywhere in the repo, so this PR removes them.