Fix build instructions #408
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
=======================================
Coverage 82.05% 82.05%
=======================================
Files 21 21
Lines 858 858
Branches 89 89
=======================================
Hits 704 704
Misses 154 154 🚀 New features to boost your workflow:
|
mcbarton
force-pushed
the
Fix-build-instructions
branch
from
f43d6b4 to
a9dc64f
Compare
mcbarton
commented
Nov 10, 2025
| cd build | ||
| cmake .. -D CMAKE_PREFIX_PATH=$CONDA_PREFIX -D CMAKE_INSTALL_PREFIX=$CONDA_PREFIX -D CMAKE_INSTALL_LIBDIR=lib | ||
| make check-xeus-cpp | ||
| make install |
Collaborator
Author
There was a problem hiding this comment.
I am not moving make install here because I think that is where it should be. Without it the kernel tests all error for me, since it assumes the kernels have been installed.
mcbarton
commented
Nov 10, 2025
|
|
||
| .. code-block:: bash | ||
| cd ../../test |
Collaborator
Author
There was a problem hiding this comment.
This change is needed because we no longer cd into the test folder insider the build folder to run the C++ tests. We stay inside the build folder and run check-xeus-cpp. That means the source test folder is now only one folder up instead of 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
With all the changes made in the last few weeks, some necessary changes to the build instructions fell through the cracks when getting reviews. This PR fixes them.
Fixes # (issue)
Type of change
Please tick all options which are relevant.