[cmake] Enumerate all source and include files. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
force-pushed
the
cmake-add-missing-files
branch
from
0d90e5e to
f0ac8e9
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
force-pushed
the
cmake-add-missing-files
branch
from
f0ac8e9 to
970bbd8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
- Coverage 49.32% 46.98% -2.35%
==========================================
Files 13 15 +2
Lines 742 779 +37
==========================================
Hits 366 366
- Misses 376 413 +37
... and 1 file with indirect coverage changes
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/xmagics/os.cpp
Outdated
| namespace xcpp | ||
| { | ||
| argparser writefile::get_options() | ||
| void writefile::get_options(argparser &argpars) |
There was a problem hiding this comment.
warning: method 'get_options' can be made static [readability-convert-member-functions-to-static]
src/xmagics/os.hpp:22:
- void get_options(argparser& argpars);
+ static void get_options(argparser& argpars);
vgvassilev
force-pushed
the
cmake-add-missing-files
branch
from
970bbd8 to
562edb6
Compare
vgvassilev
force-pushed
the
cmake-add-missing-files
branch
from
562edb6 to
2aa7764
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of reducing the size of #14.