Merged
Conversation
Unrelated to branch, but good adding
JGarciaCondado
requested changes
Sep 10, 2025
Contributor
JGarciaCondado
left a comment
There was a problem hiding this comment.
Please change to always subsampling, not based on a ratio. Open an Issue saying that the user should be allowed to change this if they want. Explain why the specific seed was set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #76
When training a logistic regression classifier for 2 unbalanced classes using age deltas or features (or whatever), we use majority class subsampling. We used to do it before going into the Cross-Validation procedure, leading to potential optimistic biases and underutilization of the data.
Now we put all the data available in the CV, and we undersample the majority class for each CV fold, avoiding the described problem.