Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch collection view updates #28

Open
wants to merge 13 commits into
base: 2.0-beta
Choose a base branch
from
Open

Batch collection view updates #28

wants to merge 13 commits into from

Conversation

JosephDuffy
Copy link
Member

@JosephDuffy JosephDuffy mentioned this pull request Jan 18, 2021
Closed
@JosephDuffy JosephDuffy requested a review from shaps80 January 23, 2021 22:05
@JosephDuffy
Copy link
Member Author

@shaps80 could use your help on this one. This is a very complex change but it improves performance a lot when performing a lot of updates.

I think it needs more tests, and a couple of them need to be fixed.

This could become a big selling point for Composed but it need to be correct!

@JosephDuffy
Copy link
Member Author

This is my biggest challenge at the moment with Composed. I think there's promise in going down the route of checking which indexes are "available" (like how removeElements(at:) works) but having some proper terms for this and creating a more generalised version is currently stumping me.

Any ideas/tests/fixes would be very welcome @shaps80!

@JosephDuffy JosephDuffy marked this pull request as ready for review February 9, 2021 11:39
@JosephDuffy
Copy link
Member Author

There are parts that could be improved (reloading sections for example) but the general structure and logic is done now.

More tests are welcome but I don't have any specific scenarios that I know don't work.

@shaps80
Copy link
Collaborator

shaps80 commented Feb 12, 2021

Hey sorry I didn't have time recently to look into this when you asked. I'll review today 100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaps80 shaps80 Awaiting requested review from shaps80

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JosephDuffy @shaps80