Add packcheck-remote to work with remote repositories directly #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harendra-kumar
requested changes
May 25, 2021
adithyaov
force-pushed
the
packcheck-remote
branch
from
689a2c6 to
9d20740
Compare
adithyaov
force-pushed
the
packcheck-remote
branch
from
9d20740 to
ae46ab3
Compare
| echo "Running ${PACKCHECK_DIR}/packcheck.sh with clean environment and CHECK_ENV on..." | ||
| echo "No environment variables are honored, you have to specifiy ALL the" | ||
| echo "parameters explicitly on the command line, including PATH." | ||
| echo | ||
|
|
||
| /usr/bin/env -i CHECK_ENV=y $(dirname $0)/packcheck.sh $* | ||
| PACKCHECK_CLI_OPTS_ARR=("$@") |
There was a problem hiding this comment.
Just quoting $* should work here e.g. /usr/bin/env -i CHECK_ENV=y $(dirname $0)/packcheck.sh "$*"
There was a problem hiding this comment.
This does not work. a="b c d" would become a=b c d.
| esac | ||
| done | ||
|
|
||
| try_git_clone_and_merge "$REMOTE" "$CHECKOUT" "$MERGE" "$DIRECTORY" "$FORCE" "$PACKCHECK_CLI_OPTS" |
There was a problem hiding this comment.
Can't we just pass "$*" instead of processing $@?
There was a problem hiding this comment.
This does not work. a="b c d" would become a=b c d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.