Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow worker.*.maxContainers to be 0 #372

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KoltesDigital
Copy link

Why do we need this PR?

worker.*.maxContainers documentation states it's 250 by default, and 0 is unlimited. However, setting it to 0 makes the template skip the env var, thus taking its default value.

Changes proposed in this pull request

Take into account that they can be to set 0.

Contributor Checklist

  • Which branch are you merging into?
    • master is for changes related to the current release of the concourse/concourse:latest image and should be good to publish immediately

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not
fill out this section.

  • Code reviewed
  • Topgun tests run
  • Back-port if needed
  • Is the correct branch targeted? (master or dev)

Copy link
Member

@taylorsilva taylorsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I had to double check that setting it to zero does mean unlimited at the binary level, and it does. Good find!

@taylorsilva
Copy link
Member

@KoltesDigital Could you do the DCO signoff please? You have to amend your commit and add Signed-off-by: Author Name <[email protected]>. I think you can do git commit --amend -s to have git do it automatically for you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants