Allow worker.*.maxContainers to be 0 #372
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do we need this PR?
worker.*.maxContainers documentation states it's 250 by default, and 0 is unlimited. However, setting it to 0 makes the template skip the env var, thus taking its default value.
Changes proposed in this pull request
Take into account that they can be to set 0.
Contributor Checklist
master
is for changes related to the current release of theconcourse/concourse:latest
image and should be good to publish immediatelyReviewer Checklist
master
ordev
)