Import Placeholder from 'utopia-api' #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liady
requested review from
gbalint,
seanparsons,
Rheeseyb,
ruggi,
balazsbajorics,
maltenuhn and
bkrmendy
liady
commented
May 9, 2024
| @@ -638,7 +645,7 @@ const Components = { | |||
| children: 'not-supported', | |||
| variants: { | |||
| label: 'QuoteWithRating', | |||
| imports: `import { QuoteWithRating, Placeholder } from "/app/components/Components"`, | |||
| imports: `import { QuoteWithRating } from "/app/components/Components"`, | |||
There was a problem hiding this comment.
Placeholder isn't being used here at all
liady
commented
May 9, 2024
| @@ -20,7 +20,6 @@ import { RecommendedProducts } from '../components/RecommendedProducts' | |||
| import { loader as loaderTemplate } from './trippy-trails-template' | |||
| import { connectToMetaObjects as connectToMetaObjectsTemplate } from '../helpers/connect-metaobject' | |||
| import { Image, Money } from '@shopify/hydrogen' | |||
| import { Placeholder } from 'utopia-api' | |||
There was a problem hiding this comment.
It's not being used here at all
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
gbalint
approved these changes
May 9, 2024
bkrmendy
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
components.utopia.jsdefinesPlaceholderas imported from both/components/Componentsandutopia-api, this PR changes all of its occurences to be fromutopia-apiFixes concrete-utopia/utopia#5626