Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike/storefront components #6725

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

bkrmendy
Copy link
Contributor

Problem:
Describe the problem being addressed as succinctly as possible.

Fix:
Describe the fix you have made as succinctly as possible.

Commit Details: (< vv pls delete this section if's not relevant)

  • Renamed thing to otherThing
  • Removed cake from fridge-contents.ts
  • Did [other things]

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

Fixes #[ticket_number] (<< pls delete this line if it's not relevant)

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Try me

Copy link

relativeci bot commented Jan 30, 2025

#15432 Bundle Size — 58.3MiB (+0.12%).

78c52bb(current) vs d1d46c1 master#15431(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 1 regression
                 Current
#15432
     Baseline
#15431
Regression  Initial JS 41.27MiB(+0.17%) 41.19MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 22.19% 18.14%
No change  Chunks 20 20
No change  Assets 22 22
Change  Modules 4194(+0.07%) 4191
No change  Duplicate Modules 213 213
Change  Duplicate Code 27.2%(-0.15%) 27.24%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#15432
     Baseline
#15431
Regression  JS 58.29MiB (+100%) undefined
Regression  HTML 9.52KiB (+100%) undefined

Bundle analysis reportBranch spike/storefront-componentsProject dashboard


Generated by RelativeCIDocumentationReport issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant