Skip to content

Update meta.yaml to 3.2.1 - Please review #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 5, 2024

Conversation

bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Sep 4, 2024

Updated meta.yaml to version 3.2.1 with SHA value of fc46d222ec17431fddfc7046498ccc98af4a51f4e619cc09f6113c495b780a55

Screenshot 2024-09-04 at 8 52 56 AM

Double-checked SHA256

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@bobleesj
Copy link
Contributor Author

bobleesj commented Sep 4, 2024

@conda-forge-admin please rerender

conda-forge-webservices[bot] and others added 2 commits September 4, 2024 13:12
@bobleesj
Copy link
Contributor Author

bobleesj commented Sep 4, 2024

The tests are failing. I am looking into the problem.

@bobleesj bobleesj changed the title Update meta.yaml to 3.2.1 Update meta.yaml to 3.2.1 (Do not merge, CI failing) Sep 4, 2024
@sbillinge
Copy link
Contributor

possibly removing the run_tests.py from the recipes will allow this to pass ci. I am not sure why this is failing and it would be good to get to the bottom of it. It may be related to what @Tieqiong is working on that pytest can't find installed tests. But a workaround is just to remove this file for now.

@bobleesj
Copy link
Contributor Author

bobleesj commented Sep 4, 2024

possibly removing the run_tests.py from the recipes will allow this to pass ci. I am not sure why this is failing and it would be good to get to the bottom of it. It may be related to what @Tieqiong is working on that pytest can't find installed tests. But a workaround is just to remove this file for now.

Yes. I do want to understand the role of run_tests.py Investigating.

I certainly see that in the CI it's being executed as you've pointed out a while ago.

@sbillinge
Copy link
Contributor

Please remove it for now and we can merge this. I think perhaps the solution is what @Tieqiong found which is a pretty big fix

@bobleesj
Copy link
Contributor Author

bobleesj commented Sep 4, 2024

CI fails after removing run_tests.py but it gives a good error message:

export SRC_DIR=/home/conda/feedstock_root/build_artifacts/diffpy.structure_1725471966662/test_tmp
import: 'diffpy'
import: 'diffpy.structure'
import: 'diffpy.structure.parsers'
import: 'diffpy.structure.applications'
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/diffpy.structure_1725471966662/test_tmp/run_test.py", line 11, in <module>
    import diffpy.structure.applications
ModuleNotFoundError: No module named 'diffpy.structure.applications'
WARNING: Tests failed for diffpy.structure-3.2.1-pyhd8ed1ab_0.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken
Traceback (most recent call last):

I will look into diffpy.structure.applications

@bobleesj bobleesj changed the title Update meta.yaml to 3.2.1 (Do not merge, CI failing) Update meta.yaml to 3.2.1 - Please review Sep 4, 2024
@@ -34,9 +31,8 @@ test:
- diffpy
- diffpy.structure
- diffpy.structure.parsers
- diffpy.structure.applications
- diffpy.structure.apps
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on 3.2.0 release

@bobleesj
Copy link
Contributor Author

bobleesj commented Sep 4, 2024

@sbillinge Please review and merge! I will test via both pip install and conda install.

@sbillinge sbillinge merged commit 90aa6eb into conda-forge:main Sep 5, 2024
3 checks passed
@bobleesj bobleesj deleted the 3.2.1 branch September 5, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants