fix: Create parent directories for file storage #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelzw
changed the title
pavelzw
commented
Feb 5, 2025
Comment on lines
+101
to
+108
| let parent = self | ||
| .path | ||
| .parent() | ||
| .ok_or(FileStorageError::IOError(std::io::Error::new( | ||
| std::io::ErrorKind::NotFound, | ||
| "Parent directory not found", | ||
| )))?; | ||
| std::fs::create_dir_all(parent)?; |
There was a problem hiding this comment.
this is the actual issue
|
While testing some more I ran into some more issues with the S3 credentials in the login. So I fixed that so I can add a test in pixi for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://discord.com/channels/1082332781146800168/1085116502375673876/1336680865664733197
this also refactors the error handling of authentication storage