Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

housekeeping #19

Merged
merged 19 commits into from
May 29, 2024
Merged

housekeeping #19

merged 19 commits into from
May 29, 2024

Conversation

alarbada
Copy link

@alarbada alarbada commented Mar 13, 2024 •
edited
Loading

Description

  • Made linter config stricter
  • Fix the consequent linter errors
  • Track used tools in tools.go
  • Improve github linter workflow
  • Fix missing "alarbada -> conduit labs" rename

Quick checks:

  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@alarbada alarbada requested a review from a team as a code owner March 13, 2024 19:21
@alarbada alarbada changed the title Alarbada/housekeeping housekeeping Mar 13, 2024
@alarbada alarbada enabled auto-merge (squash) March 13, 2024 19:25
@alarbada alarbada disabled auto-merge March 13, 2024 19:25
@alarbada alarbada self-assigned this Mar 13, 2024
raulb
raulb previously approved these changes Mar 14, 2024
View reviewed changes
lovromazgon
lovromazgon reviewed Mar 14, 2024
View reviewed changes
@raulb raulb dismissed their stale review March 14, 2024 16:13

Looks like this still needs some things I missed.

@alarbada alarbada requested review from lovromazgon and raulb April 9, 2024 22:03
lovromazgon
lovromazgon approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💪

@alarbada alarbada merged commit 7f97c97 into main May 29, 2024
3 checks passed
@alarbada alarbada deleted the alarbada/housekeeping branch May 29, 2024 09:16
@alarbada alarbada restored the alarbada/housekeeping branch May 29, 2024 09:16
@alarbada alarbada deleted the alarbada/housekeeping branch May 29, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

@raulb raulb Awaiting requested review from raulb

Assignees

@alarbada alarbada

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alarbada @raulb @lovromazgon