Refactor, fix boolean cookie attributes, and add test coverage#13
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/conedevelopment/qkie/sessions/b0cee0f1-8158-43c4-b960-72e48a5a1b8a Co-authored-by: iamgergo <6567179+iamgergo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Explore refactoring options and add test coverage
Refactor, fix boolean cookie attributes, and add test coverage
Mar 27, 2026
Member
|
@copilot Could you add a GH action as well that runs the tests? |
Agent-Logs-Url: https://github.com/conedevelopment/qkie/sessions/2bc628d7-cfbb-4bf6-a0fc-e08c3280cfbf Co-authored-by: iamgergo <6567179+iamgergo@users.noreply.github.com>
Contributor
Author
Copilot stopped work on behalf of
iamgergo due to an error
March 27, 2026 07:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Secure: true) emittedSecure=trueinstead of the spec-correctSecure;falsevalues now correctly omit the attribute_getCookiePattern(key)to eliminate duplicated regex construction inget()andisset()set()cookie string builder — replacereduce+initialValuewith cleanfilter+mapvitest.config.js,devDependencies, updatedpackage.jsontest script)_qualify(), and_getCookiePattern().github/workflows/test.yml) that runs tests on every push and pull request📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.