-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SecureComms: E2e Test SecureComms without KBS #2089
Merged
davidhadas
merged 1 commit into
confidential-containers:main
from
davidhadas:secComms_test_no_kbs
Dec 19, 2024
Merged
SecureComms: E2e Test SecureComms without KBS #2089
davidhadas
merged 1 commit into
confidential-containers:main
from
davidhadas:secComms_test_no_kbs
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d7b9676
to
6dcef0f
Compare
f08e2d3
to
f582a4e
Compare
26d3602
to
524869d
Compare
9b5b9b4
to
0c3db17
Compare
a7cf406
to
2331371
Compare
c89bfc7
to
be301d2
Compare
src/cloud-api-adaptor/test/provisioner/libvirt/provision_common.go
Outdated
Show resolved
Hide resolved
551140b
to
6bd5e10
Compare
Add support for e2e testing SecureComms without KBS Signed-off-by: David Hadas <[email protected]>
6bd5e10
to
61929c7
Compare
stevenhorsman
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me. Thanks for the updates!
bpradipt
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
464f734
into
confidential-containers:main
42 of 43 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support testing SecureComms without KBS
See
Should be merged after #2065