Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecureComms: E2e Test SecureComms without KBS #2089

Merged

Conversation

davidhadas
Copy link
Member

@davidhadas davidhadas commented Oct 6, 2024

Support testing SecureComms without KBS

See

Should be merged after #2065

@davidhadas davidhadas requested a review from a team as a code owner October 6, 2024 19:34
@davidhadas davidhadas force-pushed the secComms_test_no_kbs branch from d7b9676 to 6dcef0f Compare October 6, 2024 19:35
@davidhadas davidhadas changed the title SecureComms: Add support daemonConfig SecureComms: Test SecureComms without KBS Oct 6, 2024
@davidhadas davidhadas changed the title SecureComms: Test SecureComms without KBS SecureComms: E2e Test SecureComms without KBS Oct 7, 2024
@stevenhorsman stevenhorsman added the test_e2e_libvirt Run Libvirt e2e tests label Oct 7, 2024
@davidhadas davidhadas force-pushed the secComms_test_no_kbs branch 25 times, most recently from f08e2d3 to f582a4e Compare October 11, 2024 15:52
@davidhadas davidhadas force-pushed the secComms_test_no_kbs branch 3 times, most recently from 9b5b9b4 to 0c3db17 Compare December 12, 2024 10:39
@davidhadas davidhadas force-pushed the secComms_test_no_kbs branch 3 times, most recently from a7cf406 to 2331371 Compare December 12, 2024 15:24
@stevenhorsman stevenhorsman marked this pull request as draft December 12, 2024 17:07
@davidhadas davidhadas force-pushed the secComms_test_no_kbs branch 4 times, most recently from c89bfc7 to be301d2 Compare December 13, 2024 09:15
src/cloud-api-adaptor/libvirt/config_libvirt.sh Outdated Show resolved Hide resolved
src/cloud-api-adaptor/test/e2e/common_suite.go Outdated Show resolved Hide resolved
src/cloud-api-adaptor/test/e2e/common_suite.go Outdated Show resolved Hide resolved
src/cloud-api-adaptor/test/e2e/main_test.go Outdated Show resolved Hide resolved
src/cloud-api-adaptor/test/provisioner/provision.go Outdated Show resolved Hide resolved
@davidhadas davidhadas force-pushed the secComms_test_no_kbs branch 7 times, most recently from 551140b to 6bd5e10 Compare December 14, 2024 14:43
Add support for e2e testing SecureComms without KBS

Signed-off-by: David Hadas <[email protected]>
@stevenhorsman stevenhorsman marked this pull request as ready for review December 16, 2024 13:57
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. Thanks for the updates!

@davidhadas davidhadas requested a review from bpradipt December 17, 2024 15:05
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@davidhadas davidhadas merged commit 464f734 into confidential-containers:main Dec 19, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test_e2e_libvirt Run Libvirt e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants