Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting tag remove fix #55

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Setting tag remove fix #55

merged 2 commits into from
Aug 9, 2024

Conversation

laliconfigcat
Copy link
Member

Describe the purpose of your pull request

Setting tag remove fix.

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@laliconfigcat laliconfigcat requested a review from a team as a code owner August 9, 2024 09:17
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
58.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@laliconfigcat laliconfigcat merged commit 7abfc0a into main Aug 9, 2024
2 of 3 checks passed
@laliconfigcat laliconfigcat deleted the tagfix branch August 9, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z4kn4fein z4kn4fein z4kn4fein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laliconfigcat @z4kn4fein