Expose scrub.invalid.names config to scrub invalid schema names#287
Open
Chaitanya Mukka (mukkachaitanya) wants to merge 1 commit intomasterfrom
Open
Expose scrub.invalid.names config to scrub invalid schema names#287Chaitanya Mukka (mukkachaitanya) wants to merge 1 commit intomasterfrom
scrub.invalid.names config to scrub invalid schema names#287Chaitanya Mukka (mukkachaitanya) wants to merge 1 commit intomasterfrom
Conversation
Chaitanya Mukka (mukkachaitanya)
requested a review
from a team
as a code owner
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
confluentinc/schema-registry#1873 introduced the option to scrub invalid schema names, but the storage connectors can't take advantage of it as it's not an exposed config.
Solution
Expose the option to be configured. A lucrative alternative here would be instead to have a passthrough, say
formatter.avro.*which let through all ofAvroDataConfigoptions instead of exposing them one by one.Does this solution apply anywhere else?
If yes, where?
Test Strategy
Testing done:
Release Plan