Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-3429: Add new read-only endpoint_suffix attribute to confluent_network resource & data source #575

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

linouk23
Copy link
Contributor

@linouk23 linouk23 commented Feb 26, 2025

Release Notes

New Features

  • Added new endpoint_suffix computed attribute to confluent_network resource and and corresponding data source.

Checklist

  • I can successfully build and use a custom Terraform provider binary for Confluent.
  • I have verified my PR with real Confluent Cloud resources in a pre-prod or production environment, or both.
  • I have attached manual Terraform verification results or screenshots in the Test & Review section below.
  • I have included appropriate Terraform acceptance or unit tests for any new resource, data source, or functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have updated the corresponding documentation and include relevant examples for this PR.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Check this box if the feature is enabled for certain organizations only

What

Blast Radius

References

Test & Review

WIP

Notes

This PR also updates confluent_network.go to use the new SDK version networking/v0.14.0 instead of networking/v0.12.0.

Unfortunately, there were some minor struct changes between 0.14.0 and 0.12.0. Given that 0.14.0 is the correct version, we decided to update the client code as well. Our acceptance tests cover both the connection_types and zone_info attributes (these are the attributes with updated SDK structs) as well.

@Copilot Copilot bot review requested due to automatic review settings February 26, 2025 01:46
@linouk23 linouk23 requested a review from a team as a code owner February 26, 2025 01:46
@linouk23 linouk23 marked this pull request as draft February 26, 2025 01:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

docs/data-sources/confluent_network.md:88

  • The phrase 'fpr example' appears to be a typo. Consider replacing 'fpr example' with 'for example'.
- `endpoint_suffix` - (Optional String) The endpoint suffix for the network if applicable, for example, ".n-abc123.us-east-1.aws.glb.confluent.cloud". It is the concatenation of the subdomain separator (fpr example, '.' or '-') and the dns domain. For a Flink endpoint written as: "flink.$networkid.$region.$cloud.confluent.cloud" the endpoint_suffix would be ".$networkid.$region.$cloud.confluent.cloud". The full endpoint can be obtained by concatenating "flink" + endpoint_suffix.

docs/resources/confluent_network.md:156

  • The text 'fpr example' seems to be a typo; it should be corrected to 'for example'.
- `endpoint_suffix` - (Optional String) The endpoint suffix for the network if applicable, for example, ".n-abc123.us-east-1.aws.glb.confluent.cloud". It is the concatenation of the subdomain separator (fpr example, '.' or '-') and the dns domain. For a Flink endpoint written as: "flink.$networkid.$region.$cloud.confluent.cloud" the endpoint_suffix would be ".$networkid.$region.$cloud.confluent.cloud". The full endpoint can be obtained by concatenating "flink" + endpoint_suffix.
@linouk23 linouk23 changed the title CLI-3421: Add new read-only endpoint_suffix attribute to confluent_network resource & data source CLI-3429: Add new read-only endpoint_suffix attribute to confluent_network resource & data source Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant