Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support display_name argument in network_link_service data source #578

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

t0ffel
Copy link

@t0ffel t0ffel commented Feb 28, 2025

Release Notes

New Features

  • Add display_name argument to network_link_service data source. Make id argument optional

Bug Fixes

  • [Briefly describe any bugs fixed in this PR].

Examples

  • [Briefly describe any Terraform configuration example updates in this PR].

Checklist

  • I can successfully build and use a custom Terraform provider binary for Confluent.
  • I have verified my PR with real Confluent Cloud resources in a pre-prod or production environment, or both.
  • I have attached manual Terraform verification results or screenshots in the Test & Review section below.
  • I have included appropriate Terraform acceptance or unit tests for any new resource, data source, or functionality.
  • I confirm that this PR introduces no breaking changes or backward compatibility issues.
  • I have updated the corresponding documentation and include relevant examples for this PR.
  • I have indicated the potential customer impact if something goes wrong in the Blast Radius section below.
  • I have put checkmarks below confirming that the feature associated with this PR is enabled in:
    • Confluent Cloud prod
    • Confluent Cloud stag
    • Check this box if the feature is enabled for certain organizations only

What

Addresses #548
Usually when using data source we want to get the id of the resource given some parameters like display name. The PR allows for exactly that.

Blast Radius

data source is read-only, won't apply any changes.

References

#548

Test & Review

tested with acceptance tests and used the provider manually to obtain NLS data source.

@t0ffel t0ffel requested a review from a team as a code owner February 28, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant