Shrink ProgressDrawTarget size #277
Conversation
Size went down from 112 to 96 bytes
Only the amount of progress lines (total lines - orphan lines) was ever used from `last_state`. Size went down from 96 to 64 bytes
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
I like the last_state -> last_line_count change, that seems like a nice simplification. On the other hand, I'm less sure about removing the Option wrappers in favor of using sentinel values if the main benefit is just a few bytes of memory usage.
| || rate.is_none() | ||
| || last_draw.is_none() | ||
| || last_draw.unwrap().elapsed() > rate.unwrap() | ||
| || rate == Duration::from_secs(0) |
There was a problem hiding this comment.
I honestly don't like this use of a sentinel value. The benefit of saving 8 bytes doesn't really seem worth it to me.
There was a problem hiding this comment.
|| rate == Duration::from_secs(0) could be removed without affecting behavior (leaving just forced || finished || elapsed > rate), and there is some precedent for this kind of usage of duration, see rust-lang/rust#73544, and rust-lang/rust#84084 which stabilizes Duration::is_zero. However, I'm fine with reverting this part of the PR if that's not convincing
|
Okay, I will merge this. |
2 participants
No description provided.