Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: settings general api #477

Merged
merged 1 commit into from
Dec 22, 2023
Merged

feat: settings general api #477

merged 1 commit into from
Dec 22, 2023

Conversation

leduyhien152
Copy link
Collaborator

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 21, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: d70679f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 9:43am
websites-mochi ✅ Ready (Inspect) Visit Preview Dec 22, 2023 9:43am

zlatanpham
zlatanpham approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@zlatanpham zlatanpham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leduyhien152 leduyhien152 force-pushed the feat/settings-general-api branch from bc12587 to 6aa83d1 Compare December 22, 2023 08:14
@leduyhien152 leduyhien152 force-pushed the feat/settings-general-api branch 2 times, most recently from 31e7f9e to 62f313a Compare December 22, 2023 08:33
@leduyhien152 leduyhien152 force-pushed the feat/settings-general-api branch from 62f313a to d70679f Compare December 22, 2023 09:15
@zlatanpham zlatanpham merged commit 00b5ee9 into main Dec 22, 2023
6 checks passed
@zlatanpham zlatanpham deleted the feat/settings-general-api branch December 22, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zlatanpham zlatanpham zlatanpham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leduyhien152 @zlatanpham