This repository has been archived by the owner on Mar 6, 2020. It is now read-only.
Rebuild standard library when building with -a and -f #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for constabulary#328 which prevents static builds when target and host have the same GOOS and GOARCH. It does this by considering all packages, including the standard library, as stale when running `gb build -a -f`. Previously the `-f` flag ommitted the standard library.
|
Not LGTM. We shouldn't need a ForceAll, Force should just mark any standlib packages stale during package resolution. |
|
Hello, I've fixed the build for the testing/testmain changes in Go 1.8, #657. Please rebase your change and push again. Sorry for the delay, I've recently changed jobs. Thanks Dave |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for #328 which prevents static builds when target and host have the same GOOS and GOARCH. It does this by considering all packages, including the standard library, as stale when running
gb build -a -f. Previously the-fflag ommitted the standard library.