This repository has been archived by the owner on Mar 6, 2020. It is now read-only.
Treat CGO_ENABLED="0" the same as cross-compiling. #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that explicitly disabling cgo using CGO_ENABLED="0" in order to get a static binary will work even when the libraries in GOROOT have been compiled with cgo enabled. Otherwise it looks like gb will use the packages built with cgo in GOROOT even when cgo has been disabled.
|
Any updates on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that explicitly disabling cgo using CGO_ENABLED="0" in
order to get a static binary will work even when the libraries in
GOROOT have been compiled with cgo enabled.
This could be an easy work around for #328