File fetcher #20
Closed
File fetcher #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included 2 possible implementations : - using sync.Map optimised for high concurrency read/writes - using base map with RWMutex lock/unlock better performing for low-concurrency read/writes
Removed concurrency handling Added hash map comparison of local + fetched images Added cli to ask user to choose between remote fetcher and file fetcher Added barebones files of remote fetcher and file fetcher with test image lists
Modified image list comparison to work via hash map comparison Setup of skeleton files for file fetcher and http fetcher
Updated user feedback to be more concise Moved List call in-memory-store to not proc when hashes are equal
Reworked main's user interface to automatically recognise and validate URL or filepath Reworked http-fetcher to accept full URLs Added images.json test file
http-fetcher : Now using correct Harbor v2 API Local image list is based on tag list retrieved via API file-fetcher : Created JSON struct with name, digest and repository URL This data, with optional tag name, can be used to make docker pull commands using only url + digest
|
http-fetcher changes :
file-fetcher changes :
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked main/UI to ask for single input that is automatically categorised as URL or filepath.
File is accessed relatively from working directory