Userspace Convertor: Manifest Deduplication #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanreyl
force-pushed
the
esrey/prevent-manifest-reconvert
branch
2 times, most recently
from
7edd471 to
edb2628
Compare
WaberZhuang
reviewed
Jan 12, 2024
cmd/convertor/resources/samples/mysql-db-manifest-cache-sample-workload.sh
Outdated
Show resolved
Hide resolved
Adds manifest deduplication, which prevents re-conversion of an already converted image if its result is known and already stored within the registry. This change also includes adjustments to support cross repo mounts for whole images, improvments for the userspace db functionality, usage samples and corresponding unit tests. Signed-off-by: Esteban Rey <[email protected]>
estebanreyl
force-pushed
the
esrey/prevent-manifest-reconvert
branch
from
edb2628 to
c7e6fee
Compare
|
I added the mentioned changes, can we revisit this to get it merged in? |
|
@WaberZhuang ptal |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds manifest deduplication, which prevents re-conversion of an already converted image if its result is known and already stored within the registry. This change also includes adjustments to support cross repo mounts for whole images, improvements for the userspace db functionality, usage samples and corresponding unit tests.
What this PR does / why we need it:
This change extends the functionality of the user space convertor's deduplication functionality to avoid reconverting already converted manifests. This is an optimization to avoid converting duplicates.
Which issue(s) this PR fixes:
Fixes #249
Please check the following list: