Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: icmd is not usable to test when binary expect a console #3883

Open
apostasie opened this issue Feb 14, 2025 · 1 comment
Open

CI: icmd is not usable to test when binary expect a console #3883

apostasie opened this issue Feb 14, 2025 · 1 comment
Assignees
Labels
area/ci e.g., CI failure bug Something isn't working

Comments

@apostasie
Copy link
Contributor

Description

icmd passes an io.Multiwriter for stdout and stderr of the underlying command.

So (even if stdout is a proper pty), the command will still bail out if it requires a console (because "inappropriate ioctl for device").

That, along with the gymnastic in containerd/console - took me half a day to figure out why the eff I would not get anything on out with attach tests.

I am not sure we should continue using icmd.
The added value of it is rather limited (literally a few dozens lines of code that we are still using) , and I am not particularly interested in going over there to hack on it.

I will bypass it so that we can get #3591 in either way, so, might be time to bite the bullet and ditch it.

Steps to reproduce the issue

Describe the results you received and expected

na

What version of nerdctl are you using?

main

Are you using a variant of nerdctl? (e.g., Rancher Desktop)

None

Host information

No response

@apostasie apostasie added the kind/unconfirmed-bug-claim Unconfirmed bug claim label Feb 14, 2025
@AkihiroSuda AkihiroSuda added bug Something isn't working area/ci e.g., CI failure and removed kind/unconfirmed-bug-claim Unconfirmed bug claim labels Feb 14, 2025
@apostasie
Copy link
Contributor Author

/dibs

I'll get us away from icmd once I am done with the CI-build series.

@AkihiroSuda can you assign?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci e.g., CI failure bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants