-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add support for writing to ptys #3591
Conversation
Failure is unrelated. |
21445d5
to
fd5e26d
Compare
cfc556d
to
7be13a1
Compare
Ok, back on this... Refresher: the motivation for this overall is to get rid of unbuffer, which has issues:
The proposed solution introduces a pure go implementation leveraging ptmx for test tooling. The second commit uses the above to rewrite The third separate commit fixes #3881 - as I tripped it while working on this. Note that icmd is problematic (see #3883) and we might have to get rid of it eventually. Also note that this PR removes entirely Finally, the rewritten tests should see a decent speed boost. If this all checks-out with you folks, next PR will rewrite other tests using unbuffer so that we can close the chapter on it. CI is pending, so there might be a few more minor adjustments (will mark "ready" when it is green), but otherwise, this is ready for review. |
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
sorry for my lack of responsiveness, thank you for your efforts. |
No problem at all @fahedouch |
This is the next step in removing
unbuffer
from our testing, adding the ability to write to stdin with ptys.