Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: output log even log is rotated #3200

Merged
merged 2 commits into from
Aug 5, 2024
Merged

fix: output log even log is rotated #3200

merged 2 commits into from
Aug 5, 2024

Conversation

xyz-li
Copy link
Contributor

@xyz-li xyz-li commented Jul 7, 2024

Fix the bug nerdctl not outputting log after log file rotation.
Fixes: #3199

@xyz-li xyz-li force-pushed the main branch 5 times, most recently from 769c82a to c1c5879 Compare July 7, 2024 07:22
@xyz-li xyz-li changed the title [fix] output log even log is rotated fix: output log even log is rotated Jul 7, 2024
@xyz-li
Copy link
Contributor Author

xyz-li commented Jul 7, 2024

@zhaojizhuang

@xyz-li xyz-li requested a review from fahedouch July 9, 2024 06:47
@xyz-li xyz-li force-pushed the main branch 18 times, most recently from bdd3ce4 to 80b31e1 Compare July 12, 2024 12:20
@xyz-li xyz-li force-pushed the main branch 6 times, most recently from 063b40a to 278e20e Compare July 16, 2024 07:56
@xyz-li xyz-li changed the title fix: output log even log is rotated WIP: fix: output log even log is rotated Jul 16, 2024
@xyz-li xyz-li changed the title WIP: fix: output log even log is rotated fix: output log even log is rotated Jul 16, 2024
@xyz-li xyz-li force-pushed the main branch 3 times, most recently from 53d517e to b6f412b Compare July 29, 2024 09:35
@xyz-li xyz-li requested a review from fahedouch July 31, 2024 02:11
@fahedouch
Copy link
Member

fahedouch commented Jul 31, 2024

please check #3259 (comment)

@fahedouch fahedouch added this to the v2.0.0 milestone Aug 4, 2024
Copy link
Member

@fahedouch fahedouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fahedouch fahedouch merged commit 1c9c66d into containerd:main Aug 5, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nerdctl will not output logs after log file is rotated
2 participants