[release/1.7] Cherry Pick Commits required to support dev containers using nerdctl and finch #3286
Conversation
Signed-off-by: CodeChanning <[email protected]>
Signed-off-by: CodeChanning <[email protected]>
Signed-off-by: CodeChanning <[email protected]>
Shubhranshu153
force-pushed
the
1.7
branch
4 times, most recently
from
984f215 to
4d60439
Compare
Signed-off-by: CodeChanning <[email protected]>
Signed-off-by: Shubharanshu Mahapatra <[email protected]>
Signed-off-by: Shubharanshu Mahapatra <[email protected]>
Shubhranshu153
force-pushed
the
1.7
branch
3 times, most recently
from
45d97b3 to
505445c
Compare
Signed-off-by: Shubharanshu Mahapatra <[email protected]>
|
commit "update testutil pkg version" should be squashed into commit "feat: adding filter infrastructure + status and event filter" |
Why? |
|
That commit needs a bit of rework and want to add test for containerd 1.7.20 . if this understanding is wrong would revert it. |
nerdctl v1.7 should continue to work with containerd v2. |
AkihiroSuda
changed the title
| 1511f6c003ace805eafeb1132727791326283cff88a923d76329e1892bba7a10 cni-plugins-linux-amd64-v1.4.1.tgz | ||
| 72644e13557cda8a5b39baf97fc5e93d23fdf7baba7700000e7e9efd8bdf9234 cni-plugins-linux-arm64-v1.4.1.tgz | ||
| 2a0ea7072d1806b8526489bcd3b4847a06ab010ee32ba3c3d4e5a3235d3eb138 cni-plugins-linux-amd64-v1.4.1.tgz | ||
| 56fe62d73942cffd8f119d2b8ecb6a062e85f529a3dbfc7aa5cd83c2c01929a7 cni-plugins-linux-arm64-v1.4.1.tgz |
There was a problem hiding this comment.
Probably CNI plugins (and also other components) should be just updated to the latest version
There was a problem hiding this comment.
Will create a separate profile to update this branch and then do the cherry pick. Thanks for the comments
There was a problem hiding this comment.
What do you mean by "profile"?
There was a problem hiding this comment.
Sorry that was auto from the keyboard, I meant pr
|
Yeah will update the test and probably do some back porting as I see even for nerdctl to 1.7.20 there are some changes in the mainline. |
|
Do you also want to cherry-pick: |
|
Yes I do want to cherry pick that for the network response. For the identifiers PR I am not sure if i should add to it, technically the issue I get is there are few of cases where the volume name is long and that leads to failure. But the identifiers PR it has a backward incompatibility for the min length (1). Without that Dev containers would work but with errors in certain cases. |
|
The identifier one seems risky for backporting. |
|
I do agree that one is risky. Will keep that out of the backport |
|
You may also want to update runc |
|
this one is closed in another pr. |
Based on the discussions on #3247
Backporting the contributions made to be able to support dev containers.