Part 5: tests #3550
Part 5: tests #3550
Conversation
apostasie
force-pushed
the
part5-tests
branch
from
b908643 to
92b6ebc
Compare
| nerdtest.KubeCtlCommand(helpers, "run", "--image", testutil.CommonImage, data.Identifier(), "--", "sleep", "Inf").Run(&test.Expected{}) | ||
| nerdtest.KubeCtlCommand(helpers, "wait", "pod", data.Identifier(), "--for=condition=ready", "--timeout=1m").Run(&test.Expected{}) | ||
| nerdtest.KubeCtlCommand(helpers, "exec", data.Identifier(), "--", "mkdir", "-p", "/tmp/whatever").Run(&test.Expected{}) | ||
| nerdtest.KubeCtlCommand(helpers, "get", "pods", data.Identifier(), "-o", "jsonpath={ .status.containerStatuses[0].containerID }").Run(&test.Expected{ | ||
| Output: func(stdout string, info string, t *testing.T) { | ||
| containerID = strings.TrimPrefix(stdout, "containerd://") | ||
| }, | ||
| }) |
There was a problem hiding this comment.
do you need to specify the namespace nerdctl-test-k8s explicitly?
There was a problem hiding this comment.
Not necessary per-se, but was asked for when the k8s env was introduced: #3296 (comment)
There was a problem hiding this comment.
Not necessary per-se
will these commands be run in the default namespace or in nerdctl-test-k8s?
There was a problem hiding this comment.
k8s namespaces are not the same as containerd namespaces (yeah, really confusing).
Commands run by nerdctl for this environment are run inside the k8s.io containerd namespace (instead of the nerdctl-test usual namespace).
Then nerdctl-test-k8s is a k8 namespace, unrelated.
apostasie
force-pushed
the
part5-tests
branch
from
92b6ebc to
6ddb9ec
Compare
|
@djdongjin I am commenting out this with the latest push https://github.com/containerd/nerdctl/compare/92b6ebc138b6d7258692b0f72541a90ba00714c4..6ddb9ec0a700068bbc2233bf011a1184a1a8c1e2 Otherwise, must-retry-tests will not be run until we merge #3535 (which this PR has been broken out of by maintainers request, as it was deemed too big). |
apostasie
force-pushed
the
part5-tests
branch
from
6ddb9ec to
c981732
Compare
|
Rebased. |
|
Folks, breaking out some changes in separate PRs: Will rebase on merge. |
apostasie
force-pushed
the
part5-tests
branch
3 times, most recently
from
32860f6 to
fbde334
Compare
|
Rebased. Marking legacy tests as flaky will be done in #3535 instead. We are left here with kube tests and tooling cleanups, registry tooling cleanup, and "commit" tests rewrite. |
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
part5-tests
branch
from
fbde334 to
9603bf4
Compare
|
Rebased. |
| containerID := "" | ||
| // NOTE: kubectl namespaces are not the same as containerd namespaces. | ||
| // We still want kube test objects segregated in their own Kube API namespace. | ||
| nerdtest.KubeCtlCommand(helpers, "create", "namespace", "nerdctl-test-k8s").Run(&test.Expected{}) |
There was a problem hiding this comment.
nerdctl-test-k8s should a constant
|
Thanks @djdongjin and @AkihiroSuda . |
Broken out of #3535