Add logo for the dark mode in readme.md #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yankay
force-pushed
the
ignore-logo-in-dark-mode
branch
4 times, most recently
from
1a0d5b1 to
027a84e
Compare
AkihiroSuda
reviewed
Oct 24, 2024
README.md
Outdated
| @@ -5,7 +5,8 @@ | |||
|
|
|||
| # nerdctl: Docker-compatible CLI for containerd | |||
|
|
|||
|  | |||
|  | |||
|  | |||
There was a problem hiding this comment.
The old method of specifying images based on the theme, by using a fragment appended to the URL (
#gh-dark-mode-onlyor#gh-light-mode-only), is closing down and will be removed in favor of the new method described above.
yankay
force-pushed
the
ignore-logo-in-dark-mode
branch
from
027a84e to
2919f11
Compare
Signed-off-by: Kay Yan <[email protected]>
yankay
force-pushed
the
ignore-logo-in-dark-mode
branch
from
2919f11 to
af25fd4
Compare
yankay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logo is not correct in the dark mode.
So, generate a light version of the logo to show in dark mode.
fix #3596