Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: disable systemd test on arm64 #3846

Merged
merged 1 commit into from
Jan 28, 2025
Merged

CI: disable systemd test on arm64 #3846

merged 1 commit into from
Jan 28, 2025

Conversation

apostasie
Copy link
Contributor

Workaround #3845

@apostasie
Copy link
Contributor Author

Not clear why the CI would fail on this changeset.

At least one of the failure is showing up regularly, possibly related to #3187 and maybe could be helped by #3836.

@AkihiroSuda can you poke the CI?

@fahedouch
Copy link
Member

Out-of-scope:

TestRunWithSystemdTrueDisabled and --systemd=true ; it looks like a naming issue

LGTM, could you please ask for arm64 image ?

@apostasie
Copy link
Contributor Author

Sure.
Done containerd/stargz-snapshotter#1957

Thanks @fahedouch

@apostasie
Copy link
Contributor Author

Out-of-scope:

TestRunWithSystemdTrueDisabled and --systemd=true ; it looks like a naming issue

Yeah, I'll rewrite these tests with the new tooling later on.

@fahedouch
Copy link
Member

Sure. Done containerd/stargz-snapshotter#1957

Thanks @fahedouch

Cool thanks

@apostasie
Copy link
Contributor Author

LGTM

@fahedouch could you "approve"?
Thanks.

fahedouch
fahedouch approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@fahedouch fahedouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fahedouch fahedouch added this to the v2.x.x (tentative) milestone Jan 28, 2025
@fahedouch fahedouch merged commit 528b852 into containerd:main Jan 28, 2025
30 checks passed
@apostasie apostasie changed the title Disable systemd test on arm64 CI: disable systemd test on arm64 Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fahedouch fahedouch fahedouch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@apostasie @fahedouch