Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: harden test pty error handling #3953

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

apostasie
Copy link
Contributor

@apostasie apostasie commented Feb 28, 2025

This is a debugging PR to help figure out and fix issues outlined in #3952

There is likely two distinct issues:

  • the first one is likely a race between copying from the master and what the container writes out - it is possibly because of the hack necessary because of icmd use of MultiWriter
  • the second one is more mysterious: it seems like in certain circumstances the container exits immediately (?)

I will likely restart the CI many times to try and reproduce the issues.

@apostasie apostasie closed this Feb 28, 2025
@apostasie apostasie reopened this Feb 28, 2025
@apostasie apostasie closed this Feb 28, 2025
@apostasie apostasie reopened this Feb 28, 2025
@apostasie apostasie closed this Feb 28, 2025
@apostasie apostasie reopened this Feb 28, 2025
@apostasie apostasie marked this pull request as ready for review February 28, 2025 22:46
@apostasie apostasie closed this Feb 28, 2025
@apostasie apostasie reopened this Feb 28, 2025
@apostasie apostasie closed this Mar 1, 2025
@apostasie apostasie reopened this Mar 1, 2025
@apostasie apostasie closed this Mar 1, 2025
@apostasie apostasie reopened this Mar 1, 2025
@apostasie
Copy link
Contributor Author

Ok, it is consistently green.

Good to merge.

@AkihiroSuda AkihiroSuda added this to the v2.0.4 milestone Mar 3, 2025
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Mar 3, 2025
@AkihiroSuda AkihiroSuda merged commit 3ac75b4 into containerd:main Mar 3, 2025
210 checks passed
@apostasie apostasie changed the title Harden test pty error handling CI: harden test pty error handling Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci e.g., CI failure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants