Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: clean-up cmd filenames #3969

Closed
wants to merge 1 commit into from

Conversation

apostasie
Copy link
Contributor

Following-on previous cmd cleanups, this one shorten / rename the files.

Anything that stutters is reduced:
cmd/nerdctl/category/category_(.+).go > cmd/nerdctl/category/$1.go

Top-level files are renamed to command.go and command_test.go.

@apostasie apostasie force-pushed the refactor-filenames branch 3 times, most recently from db14369 to 7102faa Compare March 4, 2025 01:15
@apostasie apostasie changed the title Refactor: clean-up cmd filenames [WIP] refactor: clean-up cmd filenames Mar 4, 2025
@apostasie apostasie force-pushed the refactor-filenames branch from 7102faa to ffab6b3 Compare March 4, 2025 02:20
@apostasie apostasie changed the title [WIP] refactor: clean-up cmd filenames Refactor: clean-up cmd filenames Mar 4, 2025
@apostasie apostasie marked this pull request as ready for review March 4, 2025 03:19
@apostasie
Copy link
Contributor Author

At 58 minutes+ the EL8 tests are presumably stuck.

I believe we can ignore for this specific PR - and see if I can get somewhere fixing it in #3965

@AkihiroSuda
Copy link
Member

Sorry, I'd prefer the file names to be as unique as possible

@apostasie
Copy link
Contributor Author

Sorry, I'd prefer the file names to be as unique as possible

This is the opposite of what is currently done in pkg/cmd. eg: pkg/cmd/container/commit.go.

Are you saying you would prefer them to be pkg/cmd/package/package_x.go then?

@AkihiroSuda
Copy link
Member

Are you saying you would prefer them to be pkg/cmd/package/package_x.go then?

That would be preferable when there is another x.go

@apostasie
Copy link
Contributor Author

Are you saying you would prefer them to be pkg/cmd/package/package_x.go then?

That would be preferable when there is another x.go

I see.

@apostasie apostasie closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants